test: add test for toolchain path setup #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
tests/add-setup-test
branch
from
ff9ebcd
to
40d4237
Compare
spytheman
reviewed
Apr 17, 2024
Comment on lines
+29
to
+31
| if c == unsafe { nil } { | ||
| return | ||
| } |
There was a problem hiding this comment.
imho that is a good idea in general (for logging), not just in tests.
spytheman
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test custom paths and errors the test currently redirects the output of the global logger that is defined in the loglib.
The test can be simplified when the severs initialization and setup process has progressed in it's error handling. For now, the used approach should work for asserting that paths have been set properly.